Move DateFields::era over to being a byte slice #7115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
force-pushed
the
era-bytes
branch
from
74a2520 to
8a285a8
Compare
sffc
approved these changes
Oct 16, 2025
|
The conclusion in #7104 included "Clear docs on what those fields represent and how to build them". This PR does not do that, now we have undocumented byte slices on our API. |
|
I added "ASCII byte slice" in #7105. I don't know how to document that in a more clear way, I guess I could link to era codes. |
|
I had envisioned examples about how to either construct month codes using |
|
@sffc we do not currently have these examples on DateFields. |
Manishearth
added a commit
that referenced
this pull request
Oct 20, 2025
Depends on #7115, depends on #7105 Attempt at fixing #7104. The user experience of the byte slice is a little bit worse if you want to use MonthCode::new_normal/new_leap since you have to persist those for a while. Most people will not be creating them for long, though. In theory we could produce byte versions of those methods that produce a limited range of codes. It's more a problem for our tests that need to do things like "create many codes in a loop".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Progress on #7104. I didn't touch MonthCode yet since it becomes easier after #7105 lands.